Skip to content

Comments

HDDS-12054. Move ozone debug prefix to ozone debug om prefix#7674

Merged
adoroszlai merged 3 commits intoapache:masterfrom
sarvekshayr:HDDS-12054
Jan 10, 2025
Merged

HDDS-12054. Move ozone debug prefix to ozone debug om prefix#7674
adoroszlai merged 3 commits intoapache:masterfrom
sarvekshayr:HDDS-12054

Conversation

@sarvekshayr
Copy link
Contributor

What changes were proposed in this pull request?

The prefix subcommand only works on OM using the FSO namespace so it should be under the om subcommand.

What is the link to the Apache JIRA

HDDS-12054

How was this patch tested?

Tested the patch on a docker cluster and through TestOzoneFileSystemPrefixParser.java

bash-5.1$ ozone debug om
Missing required subcommand
Usage: ozone debug om [COMMAND]
Runs OM related subcommands.
Commands:
  prefix  Parse prefix contents

bash-5.1$ ozone debug om prefix
Missing required options: '--db=<dbPath>', '--path=<filePath>', '--bucket=<bucket>', '--volume=<volume>'
Usage: ozone debug om prefix --bucket=<bucket> --db=<dbPath> --path=<filePath>
                             --volume=<volume>
Parse prefix contents
      --bucket=<bucket>   bucket name
      --db=<dbPath>       Database File Path
      --path=<filePath>   prefixFile Path
      --volume=<volume>   volume name

@adoroszlai adoroszlai added the tools Tools that helps with debugging label Jan 10, 2025
Copy link
Contributor

@Tejaskriya Tejaskriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @sarvekshayr. Overall LGTM, just a small suggestion below

Co-authored-by: Tejaskriya <87555809+Tejaskriya@users.noreply.github.com>
@adoroszlai adoroszlai merged commit da8fa24 into apache:master Jan 10, 2025
42 checks passed
@adoroszlai
Copy link
Contributor

Thanks @sarvekshayr for the patch, @Tejaskriya for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Tools that helps with debugging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants