HDDS-12054. Move ozone debug prefix to ozone debug om prefix#7674
Merged
adoroszlai merged 3 commits intoapache:masterfrom Jan 10, 2025
Merged
HDDS-12054. Move ozone debug prefix to ozone debug om prefix#7674adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
Tejaskriya
reviewed
Jan 10, 2025
Contributor
Tejaskriya
left a comment
There was a problem hiding this comment.
Thanks for the patch @sarvekshayr. Overall LGTM, just a small suggestion below
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/OMDebug.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tejaskriya <87555809+Tejaskriya@users.noreply.github.com>
adoroszlai
approved these changes
Jan 10, 2025
Contributor
|
Thanks @sarvekshayr for the patch, @Tejaskriya for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The prefix subcommand only works on OM using the FSO namespace so it should be under the om subcommand.
What is the link to the Apache JIRA
HDDS-12054
How was this patch tested?
Tested the patch on a docker cluster and through
TestOzoneFileSystemPrefixParser.java