Skip to content

HDDS-12124. Disable resource filtering for VI swap files#7736

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-12124
Jan 22, 2025
Merged

HDDS-12124. Disable resource filtering for VI swap files#7736
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-12124

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Build fails when files from hadoop-ozone/dist/src/main/compose (or similar directories) are open in VI due to the binary swap files it creates:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.3.0:copy-resources (copy-compose-files) on project ozone-dist: filtering hadoop-ozone/dist/src/main/compose/restart/.docker-compose.yaml.swp to hadoop-ozone/dist/target/compose/restart/.docker-compose.yaml.swp failed with MalformedInputException: Input length = 1 -> [Help 1]

This patch disables resource filtering for .swp files. It also moves definition of non-filtered extensions to the root POM, so that it applies to all submodules, without having to duplicate.

https://issues.apache.org/jira/browse/HDDS-12124

How was this patch tested?

gvim hadoop-ozone/dist/src/main/compose/restart/docker-compose.yaml 
mvn -DskipTests -DskipShade clean package

CI:
https://github.com/adoroszlai/ozone/actions/runs/12904340058

@adoroszlai adoroszlai added the build Pull request that modifies the build process label Jan 22, 2025
@adoroszlai adoroszlai self-assigned this Jan 22, 2025
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@adoroszlai adoroszlai merged commit bb96826 into apache:master Jan 22, 2025
41 checks passed
@adoroszlai adoroszlai deleted the HDDS-12124 branch January 22, 2025 14:32
@adoroszlai
Copy link
Contributor Author

Thanks @nandakumar131 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull request that modifies the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants