HDDS-12955. Remove getCurrentContainerThreshold from SCMSafeModeManager#8752
Closed
erichung9060 wants to merge 1 commit intoapache:masterfrom
erichung9060:HDDS-12955
Closed
HDDS-12955. Remove getCurrentContainerThreshold from SCMSafeModeManager#8752erichung9060 wants to merge 1 commit intoapache:masterfrom erichung9060:HDDS-12955
erichung9060 wants to merge 1 commit intoapache:masterfrom
erichung9060:HDDS-12955
Conversation
Contributor
|
@erichung9060, thanks for working on this. Apart from unit tests, We should properly define all the metrics that will be exposed by Until we fix (or validate) all The code change that's done in this PR will not be necessary as we are planning on completely removing this method in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed getCurrentContainerThreshold from SCMSafeModeManager and updated its usage in StorageContainerManager.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12955
How was this patch tested?
Pass all existing tests
https://github.com/erichung9060/ozone/actions/runs/16085692295