Skip to content

HDDS-13574. Remove org.apache.hadoop.fs classes#8958

Merged
jojochuang merged 2 commits intoapache:masterfrom
hevinhsu:HDDS-13574
Aug 20, 2025
Merged

HDDS-13574. Remove org.apache.hadoop.fs classes#8958
jojochuang merged 2 commits intoapache:masterfrom
hevinhsu:HDDS-13574

Conversation

@hevinhsu
Copy link
Contributor

What changes were proposed in this pull request?

Clean up hacks introduced in HDDS-10511 and HDDS-8436.

Remove deprecated classes (ByteBufferPositionedReadable, LeaseRecoverable, SafeMode, SafeModeAction) no longer needed for Hadoop 3.1/3.2 support.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13574

How was this patch tested?

https://github.com/hevinhsu/ozone/actions/runs/17062417289

Remove hacks in HDDS-10511 and HDDS-8436
@peterxcli peterxcli added the code-cleanup Changes that aim to make code better, without changing functionality. label Aug 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated Hadoop filesystem classes that were temporarily added as compatibility hacks for Hadoop 3.1/3.2 support. These classes are now available in the standard Hadoop API, making the local copies unnecessary.

  • Removes four deprecated interface classes from the org.apache.hadoop.fs package
  • Cleans up temporary compatibility code introduced in previous JIRAs (HDDS-10511 and HDDS-8436)
  • Eliminates duplicate code that is now available in newer Hadoop versions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
SafeModeAction.java Removes enum defining safe mode actions (ENTER, LEAVE, FORCE_EXIT, GET)
SafeMode.java Removes interface for filesystem safe mode operations
LeaseRecoverable.java Removes interface for lease recovery capabilities
ByteBufferPositionedReadable.java Removes interface for positioned ByteBuffer reading operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@peterxcli peterxcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jojochuang
Copy link
Contributor

Looks good could you also package-info.java?

Change-Id: I760aed963e66ed7a6f2235c8bba5a6580f1c2b56
@jojochuang jojochuang merged commit 3217d58 into apache:master Aug 20, 2025
42 checks passed
@jojochuang
Copy link
Contributor

Thanks @hevinhsu @peterxcli

@hevinhsu
Copy link
Contributor Author

Thanks @peterxcli for the reviews and @jojochuang for the review and merge.

@hevinhsu hevinhsu deleted the HDDS-13574 branch August 21, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-cleanup Changes that aim to make code better, without changing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants