HDDS-13574. Remove org.apache.hadoop.fs classes#8958
Merged
jojochuang merged 2 commits intoapache:masterfrom Aug 20, 2025
Merged
HDDS-13574. Remove org.apache.hadoop.fs classes#8958jojochuang merged 2 commits intoapache:masterfrom
jojochuang merged 2 commits intoapache:masterfrom
Conversation
Remove hacks in HDDS-10511 and HDDS-8436
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated Hadoop filesystem classes that were temporarily added as compatibility hacks for Hadoop 3.1/3.2 support. These classes are now available in the standard Hadoop API, making the local copies unnecessary.
- Removes four deprecated interface classes from the
org.apache.hadoop.fspackage - Cleans up temporary compatibility code introduced in previous JIRAs (HDDS-10511 and HDDS-8436)
- Eliminates duplicate code that is now available in newer Hadoop versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SafeModeAction.java | Removes enum defining safe mode actions (ENTER, LEAVE, FORCE_EXIT, GET) |
| SafeMode.java | Removes interface for filesystem safe mode operations |
| LeaseRecoverable.java | Removes interface for lease recovery capabilities |
| ByteBufferPositionedReadable.java | Removes interface for positioned ByteBuffer reading operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Looks good could you also package-info.java? |
Change-Id: I760aed963e66ed7a6f2235c8bba5a6580f1c2b56
Contributor
|
Thanks @hevinhsu @peterxcli |
Contributor
Author
|
Thanks @peterxcli for the reviews and @jojochuang for the review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up hacks introduced in HDDS-10511 and HDDS-8436.
Remove deprecated classes (ByteBufferPositionedReadable, LeaseRecoverable, SafeMode, SafeModeAction) no longer needed for Hadoop 3.1/3.2 support.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13574
How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/17062417289