HDDS-13600. Log s3 secret error at WARN level rather than ERROR#8967
Merged
jojochuang merged 1 commit intoapache:masterfrom Aug 27, 2025
Merged
HDDS-13600. Log s3 secret error at WARN level rather than ERROR#8967jojochuang merged 1 commit intoapache:masterfrom
jojochuang merged 1 commit intoapache:masterfrom
Conversation
sarvekshayr
approved these changes
Aug 25, 2025
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks for the contribution @ajnovice.
LGTM.
Contributor
|
Clients with incorrect headers should be tracked as a metric, and the log itself should be |
Contributor
Author
Will create Jira issue and separate PR for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing the log level for missing/unavailable S3 secret during S3 auth token validation from ERROR to WARN and refine the message.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13600
How was this patch tested?
Existing unit and integration tests