HDDS-13765. SnapshotLocalData yaml should also track snapshotId#9123
Merged
Conversation
Change-Id: Iba47aeb21663dfa407ab71339cef02c0d74b49f2
sadanand48
reviewed
Oct 8, 2025
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
LGTM overall, awaiting CI as PR is in draft.
sadanand48
approved these changes
Oct 8, 2025
Contributor
Author
|
thank you @sadanand48 for reviewing the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the local snapshot yaml file name is in the format om.db-.yaml. It would be good to have to add snapshotId in the yaml file content since this info can be used in multiple instead of depending on the file name each time.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13765
How was this patch tested?
Updated existing unit test to test the extra field