HDDS-13853. Removing HDDSLayout feature dependency from DNs. #9218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ChenSammi @sumitagrawl can you review the code changes? |
Contributor
Author
|
As per discussion, there may be inconsistencies in counters if we do upgrade -> not finalize -> downgrade -> upgrade -> finalize. So the idea is go ahead with layout based approach in SCM and DN. So closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the DataNode, we currently have only the totalBlockSize field, which is optional. When reading this value and storing the total bytes for a container in metadata, it is maintained as a simple key-value entry. Therefore, this change does not affect the reading of older data and ensures full backward compatibility.
So removing the feature finalisation checks used.
What is the link to the Apache JIRA
HDDS-13853
How was this patch tested?
Tested using CI.