HDDS-13861. Intermittent failure in testOverWriteKeyWithAndWithOutVersioning [2/2] #9261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thOutVersioning (apache#9234)" This reverts commit 1fa7e56.
…e purging of deleted table entries
…tingService in versioning test
adoroszlai
reviewed
Nov 7, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @peterxcli for digging the root cause of this failure.
| OMMetadataManager metadataManager = cluster.getOzoneManager().getMetadataManager(); | ||
| String ozoneKey = metadataManager.getOzoneKey(volumeName, bucketName, keyName); | ||
|
|
||
| OmKeyInfo omKeyInfo = metadataManager.getKeyTable(getBucketLayout()).get(ozoneKey); |
Contributor
There was a problem hiding this comment.
The part of the change related to getBucketLayout() should not be reverted, because this test uses a different layout:
vs.
To simplify things, maybe we should add a constant referencing OBJECT_STORE, and use it in both createRequiredForVersioningTest and checkExceptedResultForVersioningTest.
Comment on lines
4673
to
4657
| assertThat(rangeKVs).isNotEmpty(); | ||
| assertThat(rangeKVs.size()).isGreaterThan(0); |
Contributor
There was a problem hiding this comment.
Let's also keep isNotEmpty().
peterxcli
changed the title
Co-authored-by: Doroszlai, Attila <adoroszlai@apache.org>
peterxcli
force-pushed
the
hdds13861-intermittent-failure-in-testOverWriteKeyWithAndWithOutVersioning-take2
branch
from
f65790c to
995adbd
Compare
adoroszlai
approved these changes
Nov 7, 2025
Contributor
|
thanks @peterxcli ! |
peterxcli
deleted the
hdds13861-intermittent-failure-in-testOverWriteKeyWithAndWithOutVersioning-take2
branch
Member
Author
|
Thanks @adoroszlai @rich7420 for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13861
How was this patch tested?