HDDS-13923. Remove leftover references to custom pending label #9290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@errose28 @sarvekshayr please take a look |
sarvekshayr
approved these changes
Nov 13, 2025
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the clean up. LGTM.
errose28
approved these changes
Nov 13, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the fix @adoroszlai.
Contributor
|
|
Contributor
Author
|
Thanks @errose28, @sarvekshayr for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to HDDS-11370, which left some references to the custom PR logic using the
pendinglabel. This PR removes remaining scripts and further updates documentation.Note that
close.shwas not strictly limited to PRs withpendinglabel, but it used the same comment file that HDDS-11370 has removed, so it is broken. Instead of restoring the comment file, this change removesclose.sh, too. We should mostly rely on thestaleaction, but can still manually close PRs if needed.https://issues.apache.org/jira/browse/HDDS-13923