HDDS-14158. Parameter 'format' is unknown for maven-checkstyle-plugin:3.6.0#9483
Merged
adoroszlai merged 4 commits intoapache:masterfrom Dec 13, 2025
Merged
HDDS-14158. Parameter 'format' is unknown for maven-checkstyle-plugin:3.6.0#9483adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
szetszwo
reviewed
Dec 12, 2025
pom.xml
Outdated
| <format>xml</format> | ||
| <format>html</format> | ||
| <outputFormat>xml</outputFormat> | ||
| <outputFormat>html</outputFormat> |
Contributor
There was a problem hiding this comment.
It seems that html is not supported and the default is xml. So, let's remove both lines?
% ls -l hadoop-hdds/common/target/checkstyle-*
-rw-r--r--@ 1 szetszwo staff 56567 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-cachefile
-rw-r--r--@ 1 szetszwo staff 8959 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-checker.xml
-rw-r--r--@ 1 szetszwo staff 12660 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-header.txt
-rw-r--r--@ 1 szetszwo staff 1331 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-suppressions.xml
Contributor
Author
There was a problem hiding this comment.
Thanks @szetszwo for reviewing . Suggestions incorporated.
szetszwo
approved these changes
Dec 12, 2025
Contributor
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
adoroszlai
approved these changes
Dec 12, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed tag for maven-checkstyle-plugin under root pom.xml
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14158
How was this patch tested?
local build successful.