Skip to content

HDDS-14158. Parameter 'format' is unknown for maven-checkstyle-plugin:3.6.0#9483

Merged
adoroszlai merged 4 commits intoapache:masterfrom
navinko:HDDS-14158
Dec 13, 2025
Merged

HDDS-14158. Parameter 'format' is unknown for maven-checkstyle-plugin:3.6.0#9483
adoroszlai merged 4 commits intoapache:masterfrom
navinko:HDDS-14158

Conversation

@navinko
Copy link
Contributor

@navinko navinko commented Dec 11, 2025

What changes were proposed in this pull request?

Removed tag for maven-checkstyle-plugin under root pom.xml

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14158

How was this patch tested?

local build successful.

@navinko navinko changed the title HDDS-14158. Updated <format> tag to <outputFileFormat> HDDS-14158. Parameter 'format' is unknown for plugin 'maven-checkstyle-plugin:3.6.0:check Dec 12, 2025
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinko , thanks for working on this! Please see the comment inlined.

pom.xml Outdated
<format>xml</format>
<format>html</format>
<outputFormat>xml</outputFormat>
<outputFormat>html</outputFormat>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that html is not supported and the default is xml. So, let's remove both lines?

% ls -l hadoop-hdds/common/target/checkstyle-*
-rw-r--r--@ 1 szetszwo  staff  56567 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-cachefile
-rw-r--r--@ 1 szetszwo  staff   8959 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-checker.xml
-rw-r--r--@ 1 szetszwo  staff  12660 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-header.txt
-rw-r--r--@ 1 szetszwo  staff   1331 Dec 12 08:46 hadoop-hdds/common/target/checkstyle-suppressions.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for reviewing . Suggestions incorporated.

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo requested a review from adoroszlai December 12, 2025 19:18
@adoroszlai adoroszlai changed the title HDDS-14158. Parameter 'format' is unknown for plugin 'maven-checkstyle-plugin:3.6.0:check HDDS-14158. Parameter 'format' is unknown for maven-checkstyle-plugin:3.6.0 Dec 12, 2025
@adoroszlai adoroszlai merged commit e9fafe3 into apache:master Dec 13, 2025
44 checks passed
@adoroszlai
Copy link
Contributor

Thanks @navinko for the patch, @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants