Skip to content

Conversation

@szetszwo
Copy link
Contributor

@szetszwo szetszwo commented Jan 8, 2026

What changes were proposed in this pull request?

  • Remove the always empty shutdown() method.
  • Remove ReplicationFactor.value.
  • Remove the unused RatisPipelineProvider.conf.

What is the link to the Apache JIRA

HDDS-14384

How was this patch tested?

By existing tests.

Copy link
Contributor

@ptlrs ptlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @szetszwo.

Comment on lines 1405 to 1407
private final long blockSize;
private final long minRatisVolumeSizeBytes;
private final long containerSize;
Copy link
Contributor

@ptlrs ptlrs Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR we are now using a final filter instead of instantiating a new one.
Will the Ozone configurations mapping to these properties ever be modified dynamically?
If so, the instantiated filter won't get the updated values for these configurations.

Copy link
Contributor Author

@szetszwo szetszwo Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptlrs , thanks for reviewing this!

There are final fields such as numPipelinesPerMetadataVolume in SCMNodeManager. It is consistent to make NonWritableNodeFilter final.

For reconf, SCM currently only supports reconf admins; see below. So, the filter cannot be modified dynamically.

reconfigurationHandler =
new ReconfigurationHandler("SCM", conf, this::checkAdminAccess)
.register(OZONE_ADMINISTRATORS, this::reconfOzoneAdmins)
.register(OZONE_READONLY_ADMINISTRATORS,
this::reconfOzoneReadOnlyAdmins);
reconfigurationHandler.setReconfigurationCompleteCallback(reconfigurationHandler.defaultLoggingCallback());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @szetszwo.

@szetszwo szetszwo requested a review from jojochuang January 11, 2026 17:42
@adoroszlai adoroszlai merged commit 6d4cd1c into apache:master Jan 12, 2026
85 of 86 checks passed
@adoroszlai
Copy link
Contributor

Thanks @szetszwo for the patch, @ptlrs for the review.

@adoroszlai adoroszlai added the code-cleanup Changes that aim to make code better, without changing functionality. label Jan 12, 2026
@szetszwo
Copy link
Contributor Author

@ptlrs , @adoroszlai , thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-cleanup Changes that aim to make code better, without changing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants