HDDS-14492. Incorrect label on Containers page: 'No of Keys' should be 'No of Blocks' #9666
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch. Overall LGTM, just one minor comment.
| }, | ||
| { | ||
| title: 'No. of Keys', | ||
| title: 'No of Blocks', |
Contributor
There was a problem hiding this comment.
It should be Number of Blocks means No. of Blocks
Suggested change
| title: 'No of Blocks', | |
| title: 'No. of Blocks', |
Contributor
Author
|
Thanks @Gargi-jais11 for the review. |
Gargi-jais11
approved these changes
Jan 26, 2026
devabhishekpal
approved these changes
Jan 26, 2026
Contributor
devabhishekpal
left a comment
devabhishekpal
left a comment
There was a problem hiding this comment.
Thanks for the patch @Russole.
LGTM, +1
sreejasahithi
approved these changes
Jan 27, 2026
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @Russole for working on this , LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the Containers page label from No of Keys to No of Blocks to match the correct terminology and maintain consistency with the old UI.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14492
How was this patch tested?
All CI checks passed.