HDDS-14583. Remove dependency on commons-pool2 in hdds-common

[AdyChechani]

What changes were proposed in this pull request?

This PR moves server-only serialization utilities from hadoop-hdds/common to hadoop-hdds/framework, enabling the removal of the commons-pool2 dependency from the common module.

Changes:

• Moved three Java files from hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/ to hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/util/:
  • ObjectSerializer.java
  • WithChecksum.java
  • YamlSerializer.java
• Updated dependency in hadoop-hdds/common/pom.xml:
  • Removed org.apache.commons:commons-pool2 dependency
• Updated dependency in hadoop-hdds/framework/pom.xml:
  • Added org.apache.commons:commons-pool2 dependency

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14583

How was this patch tested?

• Compilation tests: Verified successful compilation of affected modules:
  • mvn clean compile -pl hadoop-hdds/common -am -DskipTests - SUCCESS
  • mvn clean compile -pl hadoop-hdds/framework -am -DskipTests - SUCCESS
• Successful Test run:
  • TestOmSnapshotLocalDataYaml
  • TestOmSnapshotLocalDataManager

[adoroszlai]

Thanks @AdyChechani for the patch. Please enable workflows in your fork. Also, can you please let me know your Apache Jira username?

[adoroszlai]

[INFO] --- dependency:3.9.0:analyze-only (analyze) @ hdds-server-framework ---
[ERROR] Used undeclared dependencies found:
[ERROR]    org.yaml:snakeyaml:jar:2.5:compile

Looks like we need to add snakeyaml in hadoop-hdds/framework/pom.xml:

    <dependency>
      <groupId>org.yaml</groupId>
      <artifactId>snakeyaml</artifactId>
    </dependency>

[adoroszlai]

Thanks @AdyChechani for updating the patch and enabling workflows.

CI found one more change is needed due to checkstyle problem:

hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/util/YamlSerializer.java
 1: Missing package-info.java file.

Please copy hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/package-info.java to hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/util, so that both directories have package-info.java.

[AdyChechani]

Hi @adoroszlai,

Thanks for noticing this. I have created a patch for this. Can you please tell me which local checks or scripts I should run before committing/opening a PR in the future, so I can catch these issues earlier?

Thanks!

[adoroszlai]

Can you please tell me which local checks or scripts I should run before committing/opening a PR in the future, so I can catch these issues earlier?

I recommend running build and checkstyle locally for all changes, these are quick:

mvn -DskipRecon -DskipShade -DskipTests clean verify
./hadoop-ozone/dev-support/checks/checkstyle.sh

Then push to your fork and let CI complete before opening your PR.

[adoroszlai]

Thanks @AdyChechani for the patch.