HDDS-14654. NoSuchFileException when orphan check runs after purged snapshot YAML is deleted.#9786
Draft
sadanand48 wants to merge 1 commit intoapache:masterfrom
Draft
HDDS-14654. NoSuchFileException when orphan check runs after purged snapshot YAML is deleted.#9786sadanand48 wants to merge 1 commit intoapache:masterfrom
sadanand48 wants to merge 1 commit intoapache:masterfrom
Conversation
…napshot YAML is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a purged snapshot’s YAML is deleted (all versions removed), the orphan check can still schedule that snapshot again.
The next run then tries to load the missing YAML and throws NoSuchFileException.
Root cause:
In checkForOphanVersionsAndIncrementCount, we always call incrementOrphanCheckCount(snapshotId) when isPurgeTransactionSet or the version changes, even if the YAML was just deleted (empty versions). That keeps the snapshot in snapshotToBeCheckedForOrphans even though there is nothing left to check.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14654
How was this patch tested?
Unit test added