HDDS-14710. Intermittent "Socket closed" in JacocoServer#9824
Merged
adoroszlai merged 2 commits intoapache:masterfrom Feb 26, 2026
Merged
HDDS-14710. Intermittent "Socket closed" in JacocoServer#9824adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
yandrey321
reviewed
Feb 25, 2026
| synchronizedCall(destination::visitClassExecution)); | ||
| while (reader.read()) { | ||
| ;//read until the end of the stream. | ||
| while (true) { |
Contributor
Author
There was a problem hiding this comment.
Yes, why would it be different? The purpose of this part of the change is to avoid the need for:
There was a problem hiding this comment.
I'd keep the loop condition as is and add Thread.yield() in the body to get a chance to other thread to fill the buffer for the next read().
yandrey321
suggested changes
Feb 25, 2026
dombizita
approved these changes
Feb 26, 2026
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for fixing this @adoroszlai, looks good to me.
Contributor
Author
|
Thanks @dombizita, @yandrey321 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Acceptance check sometimes encounters this harmless, but confusing error:
Fix
JacocoServerto catch the exception.Also avoid empty statement and suppression.
https://issues.apache.org/jira/browse/HDDS-14710
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/22367329262