HDDS-14672. Remove SCM finalization checkpoints#9955
Merged
sodonnel merged 8 commits intoapache:HDDS-14496-zdufrom Mar 24, 2026
Merged
HDDS-14672. Remove SCM finalization checkpoints#9955sodonnel merged 8 commits intoapache:HDDS-14496-zdufrom
sodonnel merged 8 commits intoapache:HDDS-14496-zdufrom
Conversation
added 8 commits
March 20, 2026 11:40
github-actions
bot
added
the
zdu
dombizita
approved these changes
Mar 23, 2026
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for breaking it down to smaller commits
Contributor
Author
|
Merged into the branch. Thanks for the review @dombizita |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now HDDS-14570 is complete, we can remove all the SCM finalization checkpoints. There were only there to coordinate between the SCM instances when finalizing multiple versions incase there was a failover or restart part way through. Now, a single Ratis transaction gets replayed on startup if that happens, so the code can be simplified.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14672
How was this patch tested?
Modifications to existing tests.