feat: introduce basic data types including decimal, blob and timestamp#10
Merged
Conversation
leaves12138
approved these changes
May 25, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Thanks for migrating the basic data types and logging utilities. I compared the added files with the source snapshot; they match the staged migration with ASF header normalization. The PR is based on the current main and merges cleanly. I also checked line endings/trailing whitespace and ran a lightweight public-header syntax smoke check; no blocker found.
Non-blocking note: some implementation/test files still depend on components expected to arrive in later migration PRs, such as filesystem, IO streams, string/decimal utilities, and executor futures. That looks fine for the staged migration.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce the basic data types module including:
DecimalData.Internal utilities added:
BlobDescriptor: Serializable descriptor for blob references with versioned binary format (v1/v2 compatible with Java).BlobDefs: Constants for blob file format (magic number, header layout, etc.).BlobUtils: Helper functions for separating blob/non-blob fields in Arrow schemas and arrays.Tests
BlobTestBlobDescriptorTestBlobUtilsTestDecimalTestTimestampTestLoggerTestAPI and Format
This change adds new public headers under
include/paimon/data/:blob.h—Blobclassdecimal.h—Decimalclasstimestamp.h—TimestampclassAnd extends
include/paimon/logging.hwith theLoggerinterface.No existing API or storage format is changed.