feat: add GenericLruCache, ConcurrentHashMap, MurmurHash, and Precond…#21
Open
dalingmeng wants to merge 1 commit into
Open
feat: add GenericLruCache, ConcurrentHashMap, MurmurHash, and Precond…#21dalingmeng wants to merge 1 commit into
dalingmeng wants to merge 1 commit into
Conversation
leaves12138
approved these changes
May 26, 2026
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Thanks for the PR. I reviewed the new GenericLruCache, ConcurrentHashMap, MurmurHashUtils, Preconditions, tests, and license/notice updates. I did not find any blocking issue. One minor non-blocking suggestion: Preconditions can probably include only fmt/format.h instead of fmt/base.h + fmt/core.h + fmt/format.h + fmt/ranges.h, unless the extra headers are intentionally needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
No Linked issue.
Introduce additional common utility modules to the apache/paimon-cpp codebase, including a generic LRU cache, concurrent hash map, murmur hash utilities, and precondition checks.
Tests
generic_lru_cache_test.cpp — LRU eviction, TTL expiration, concurrent access
concurrent_hash_map_test.cpp — Insert, lookup, delete, and multi-threaded correctness
murmurhash_utils_test.cpp — Hash computation correctness and consistency
preconditions_test.cpp — CheckState and CheckArgument validation
API and Format
No API or format changes.
Documentation
No documentation changes.
Generative AI tooling