fix: schema layout version compatibility#24
Closed
QuakeWang wants to merge 1 commit into
Closed
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
We don't need to do this. This format has not been publicly released yet, so there's no need to consider compatibility issues. |
Contributor
Author
Got it. I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Schema block layout changed while the file footer version stayed at v1. Existing v1 files can be parsed with the new layout, causing the legacy logical index to be read as a type header and potentially corrupting schema metadata silently.
Fix
Bump the current file version to v2 and keep v1 as the legacy format. Route schema deserialization by footer version, parse v1 with the legacy logical-index layout, and add a v2 schema layout marker for the current format.
Also add regression coverage for legacy v1 schema decoding.