fix: preserve empty projection in read_table#25
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
read_table(..., columns=[])currently skips projection because the Python wrapper checksif columns:. This makes an explicit empty projection behave the same ascolumns=None, so the convenience API returns all columns instead of a zero-column table with the row count preserved.Fix
Change the wrapper to call
reader.project(columns)whenevercolumns is not None, preserving the existing three-state projection semantics:None: read all columnsAdd a regression test for
read_table(..., columns=[]).