feat: optimize projected read buffer copies#5
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
Nice Catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projected reads already avoided unnecessary IO for sparse paged buckets, but the reader still copied buffers at several internal boundaries.
Before this PR:
read_rangescoalesced IO ranges, then copied each logical range into its ownVec<u8>.parse_column_slotcopied the decompressed page payload after parsing its header.This PR keeps the existing format and
read_rangesAPI, but adds a shared range buffer path for projected reads. The reader now borrows slices from coalesced buffers during parsing, stores paged slot locations instead of slot bytes, and letsColumnPageReaderparse from an offset inside the owned decompressed page buffer.