Merged
Conversation
luoyuxia
commented
Mar 15, 2026
bindings/go/tests/paimon_test.go
Outdated
| } | ||
| defer p.Close() | ||
|
|
||
| catalog, err := p.NewFileSystemCatalog(warehouse) |
Contributor
Author
There was a problem hiding this comment.
Will introduce some thing like catalog factory to create filesystem catalog instead of hard coding to NewFileSystemCatalog.
Now, let's just make go works.
| // The table was populated by Docker provisioning with: | ||
| // | ||
| // (1, 'alice'), (2, 'bob'), (3, 'carol') | ||
| func TestReadLogTable(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
the current api design follow python & java client. Myabe in the future we can consider have a simpler(but may not flexiable) api like:
tbl, err := paimon.OpenTable(path, paimon.NewIdentifier("default", "t1"))
if err != nil { return err }
defer tbl.Close()
reader, err := tbl.NewRecordReader(ctx)
if err != nil { return err }
defer reader.Close()
for {
rec, err := reader.NextRecord()
...
}
Contributor
Author
|
I'll add build & reelase pipline in the next follow pr, and it only support mac/linux, if needed, I can support window in next pr. |
f6bd026 to
46a0607
Compare
|
+1 |
XiaoHongbo-Hope
approved these changes
Mar 15, 2026
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #121
Brief change log
Introduce a Go binding for Apache Paimon Rust. Uses purego + libffi to call the paimon-c shared library without CGO, and the Arrow C Data Interface for zero-copy data exchange.
Brief change log
Tests
IT
API and Format
TBD
Documentation
Will add in next following pr since the api may change during review