Skip to content

feat(spec): implement partition path generation#139

Merged
JingsongLi merged 2 commits intoapache:mainfrom
QuakeWang:feat/partition-path-utils
Mar 18, 2026
Merged

feat(spec): implement partition path generation#139
JingsongLi merged 2 commits intoapache:mainfrom
QuakeWang:feat/partition-path-utils

Conversation

@QuakeWang
Copy link
Contributor

Purpose

Linked issue: close #127

Brief change log

Tests

API and Format

Documentation

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuakeWang Thanks for the pr. Left minor comments. PTAL

@QuakeWang
Copy link
Contributor Author

@QuakeWang Thanks for the pr. Left minor comments. PTAL

@luoyuxia Thanks for the review! All comments have been addressed in the latest commit:

  1. Unified all BinaryRow get_* methods to return Result — no more try_get_* / panic duality.
  2. Preserved Utf8Error source chain.
  3. Introduced PartitionComputer struct with a separate generate_part_values method.
  4. Float/Double partition keys now return Unsupported.
  5. Extracted test helpers to reduce boilerplate.

PTAL, thanks!

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 917ac26 into apache:main Mar 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement partition path generation (PartitionPathUtils)

3 participants