feat: support partitioned table in TableScan and TableRead#145
Merged
JingsongLi merged 2 commits intoapache:mainfrom Mar 25, 2026
Merged
feat: support partitioned table in TableScan and TableRead#145JingsongLi merged 2 commits intoapache:mainfrom
JingsongLi merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@JingsongLi @XiaoHongbo-Hope @luoyuxia Hi PTAL, if you have time, thanks : ) |
luoyuxia
reviewed
Mar 24, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@QuakeWang Thanks. Lgtm overall. Only one minor comment
QuakeWang
force-pushed
the
feat/partitioned-table-scan
branch
from
b307801 to
afe23ce
Compare
QuakeWang
force-pushed
the
feat/partitioned-table-scan
branch
from
29a84dd to
74009ee
Compare
|
+1 |
JingsongLi
reviewed
Mar 24, 2026
| rows.push((id.value(i), name.value(i).into(), dt.value(i).into())); | ||
| } | ||
| } | ||
| rows.sort_by_key(|(id, _, _)| *id); |
Contributor
There was a problem hiding this comment.
rows.sort_by(|a, b| a.0.cmp(&b.0).then(a.2.cmp(&b.2))) sort by partition too to ensure the determination of result sequence.
JingsongLi
reviewed
Mar 24, 2026
| }; | ||
|
|
||
| for ((partition, bucket), group_entries) in groups { | ||
| let partition_row = if !partition_keys.is_empty() { |
Contributor
There was a problem hiding this comment.
It's best not to set partition_row to None. We can assign a Binary Row EMPTY static variable to the non partitioned table, just like Java.
So here, I think we can just use inaryRow::from_serialized_bytes and optimize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #131
Brief change log
Tests
API and Format
Documentation