chore(api/auth): fix clippy failure for DLF default signer identifier#191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the CI failure from
cargo clippy --all-targets --workspace -- -D warnings.The failure was caused by a duplicated DLF signer identifier definition in the auth factory.
DLFDefaultSigner::IDENTIFIERexisted but was not referenced by the factory code path, which triggered adead_codewarning and was promoted to an error by Clippy in CI.Brief change log
"default"/"openapi"identifier definitions fromDLFAuthProviderFactoryDLFDefaultSigner::IDENTIFIERandDLFOpenApiSigner::IDENTIFIERas the single source of truthTests
cargo fmt --allcargo test -p paimoncargo clippy --all-targets --workspace -- -D warningscargo test --workspaceAPI and Format
Documentation