feat: introduce time travel for data fusion#195
Merged
XiaoHongbo-Hope merged 6 commits intoapache:mainfrom Apr 3, 2026
Merged
Conversation
JingsongLi
changed the title
JingsongLi
changed the title
QuakeWang
reviewed
Apr 3, 2026
| source: None | ||
| }); | ||
| } | ||
| Ok(snapshot) |
Contributor
There was a problem hiding this comment.
This get_snapshot() path now returns the deserialized snapshot directly, but it no longer checks snapshot.id() == snapshot_id.
That means a mismatched snapshot-{id} file will be accepted silently, and both the new time-travel path and the normal latest-snapshot path can read the wrong snapshot instead of failing fast.
I think we should keep the same id-consistency check here before merging.
Contributor
|
+1 |
XiaoHongbo-Hope
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce time travel support for the DataFusion integration, allowing users to query historical snapshots via standard SQL syntax FOR SYSTEM_TIME AS OF.
Brief change log
Tests
provision.py & read_tables.rs
API and Format
Documentation