chore: remove obsolete allow(dead_code) annotations#206
Merged
JingsongLi merged 1 commit intoapache:mainfrom Apr 5, 2026
Merged
chore: remove obsolete allow(dead_code) annotations#206JingsongLi merged 1 commit intoapache:mainfrom
JingsongLi merged 1 commit intoapache:mainfrom
Conversation
luoyuxia
force-pushed
the
remove-dead-code
branch
from
d49163d to
f72499d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
This PR removes allow(dead_code) annotations that were introduced earlier during implementation to temporarily suppress warnings for code that had not yet been wired up.
As the related code paths are now being used, these annotations are no longer necessary. Cleaning them up makes the codebase tidier and helps keep warning suppression limited to cases where it is actually needed.
Brief change log
Tests
API and Format
Documentation