feat: add Vortex columnar file format support as optional feature#260
Merged
Conversation
Add read/write support for the Vortex file format behind a `vortex` feature flag. The writer uses a background task with kanal channel for streaming writes, and the reader supports predicate pushdown and row selection. Also introduces a configurable `file.format` option (default "parquet") to replace hardcoded file extensions across all writer paths.
Remove eprintln! warning from VortexFormatWriter Drop impl, and update stale "Open parquet writer" comment in kv_file_writer.rs to be format-agnostic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| })?; | ||
|
|
||
| // Apply column projection. | ||
| if !projected_names.is_empty() { |
Contributor
There was a problem hiding this comment.
DataFusion can push projection=[] for SELECT COUNT(*). Here empty projection is treated as no projection, so Vortex still returns actual columns, and RecordBatch validation later fails against the empty requested schema.
| let batch = RecordBatch::try_new_with_options( | ||
| target_schema, | ||
| vec![], | ||
| &arrow_array::RecordBatchOptions::new().with_row_count(Some(row_count)), |
Contributor
There was a problem hiding this comment.
This early return ignores predicate filters for empty-projection reads. Empty-projection reads can return the full file
row count instead of the filtered row count.
Contributor
Author
There was a problem hiding this comment.
We should consider row_selection. Predicates are inherently designed for coarse-grained filtering; unlike in Python, the returned data is not filtered on a per-row basis.
Contributor
|
+1 |
XiaoHongbo-Hope
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add read/write support for the Vortex file format behind a
vortexfeature flag. The writer uses a background task with kanal channel for streaming writes, and the reader supports predicate pushdown and row selection. Also introduces a configurablefile.formatoption (default "parquet") to replace hardcoded file extensions across all writer paths.Brief change log
Tests
API and Format
Documentation