feat: support fixed-bucket partial-update merge engine#263
Open
QuakeWang wants to merge 2 commits intoapache:mainfrom
Open
feat: support fixed-bucket partial-update merge engine#263QuakeWang wants to merge 2 commits intoapache:mainfrom
QuakeWang wants to merge 2 commits intoapache:mainfrom
Conversation
JingsongLi
reviewed
Apr 18, 2026
Contributor
JingsongLi
left a comment
There was a problem hiding this comment.
Can we simplify some of the code? There's no need for so much validation; we just need to focus on E2E and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: part of #256
This PR delivers a minimum usable
merge-engine=partial-updateimplementation for primary-key tables with fixed buckets.It shifts the earlier groundwork-heavy approach toward end-to-end functionality, while keeping only the validation that is still necessary for correctness.
This PR does not close #256 yet. Support for
bucket=-1partial-update, including cross-partition existing-key behavior, remains follow-up work.Brief change log
merge-engine=partial-updateend to end for primary-key tablesbucket=-1anddeletion-vectors.enabled=trueexplicitly unsupported in this PRTests
API and Format
Documentation