fix: replace serde_avro_fast with apache-avro and optimize Avro reading#276
Merged
JingsongLi merged 5 commits intoApr 23, 2026
Merged
Conversation
a1a73e4 to
8172dd1
Compare
ab991f3 to
9f1f4fd
Compare
Contributor
|
@luoyuxia Thanks for the contribution! Left comments from Claude 4.7:
|
…ue usage Remove the custom AvroValue enum and conversion functions, working directly with apache_avro::types::Value. This avoids per-record HashMap allocation and recursive value conversion overhead.
Upgrade apache-avro from 0.17 to 0.21 and simplify to_avro_bytes by leveraging the existing From<apache_avro::Error> impl to replace repetitive map_err blocks with the ? operator.
f075e25 to
8b88003
Compare
Contributor
Author
|
1 & 2: fix @JingsongLi Hi, I already address the comments. |
luoyuxia
added a commit
to luoyuxia/paimon-rust
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
Replace
serde_avro_fast(LGPL-3.0-only) withapache-avroto fix the license compatibility issue, and optimize the Avro reading path by eliminating the intermediateAvroValueconversion layer.Brief change log
serde_avro_fastdependency (LGPL-3.0-only), useapache-avrofor all Avro read/write pathscargo-denyfrom 0.14.22 to 0.19.0 so incompatible licenses fail the workflowavro.rs: remove the customAvroValueenum andavro_record_to_hash_mapconversion, work directly withapache_avro::types::Valuefield_index()from the first record, use O(1) indexed access for all subsequent rows instead of per-row linear search or HashMap lookupto_avro_bytes: leverage the existingFrom<apache_avro::Error>impl to replace 4 repetitivemap_errblocks with?apache-avro: 0.17 → 0.21Tests
API and Format
No API or storage format changes.
Documentation
No.