build: fix clippy on Windows GNU with Rust 1.95#329
Merged
Conversation
JaydenHD
force-pushed
the
codex/windows-gnu-rust-lld
branch
from
f845ec6 to
c108902
Compare
JaydenHD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
With Rust stable 1.95.0 on
x86_64-pc-windows-gnu,cargo clippycan fail before reaching project lints because generated build-script executables are not runnable with the default GNU linker output (os error 193). A minimalrustchello world has the same failure on this toolchain, while linking withrust-lldproduces a runnable executable.This configures the Windows GNU target to use the Rust-provided
rust-lldlinker so clippy can run normally.Brief change log
.cargo/config.tomlwithtarget.x86_64-pc-windows-gnu.linker = rust-lld.Tests
cargo clippy --all-targets --workspace --features fulltext,vortex -- -D warningsAPI and Format
No API change.
No storage format change.
Documentation
No documentation update required.