fix(index): propagate fallible with_projection in btree index build#471
Merged
QuakeWang merged 1 commit intoJul 7, 2026
Merged
Conversation
apache#454 predates apache#460's fallible with_projection and merged without a rebase check; the unused Result fails clippy -D warnings on main and on every open PR's merge CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI on
mainis red: thecheckjob fails clippy with an unusedResultinbtree_global_index_build_builder.rs:562. #454 was written before #460 madeReadBuilder::with_projectionfallible and merged without a rebase check against it. Every open PR's merge CI now fails on the same error regardless of its own changes.(Hotfix for CI breakage — no linked issue, per the contribution checklist exception.)
Brief change log
Propagate the
Resultwith?—extract_index_rowsalready returnsResult, and a projection failure here (unknown/duplicate column) should abort the index build rather than silently read the full row.Tests
cargo clippy -p paimon --all-targets --features fulltext,vortex,mosaic -- -D warnings: clean (was failing).cargo test -p paimon --lib btree: 58 passed.API and Format
None.
Documentation
None.