Skip to content

[Improvement] Optimize return value type for table service interface#208

Merged
SteNicholas merged 1 commit intoapache:mainfrom
s7monk:optimize_table_return_type
May 5, 2024
Merged

[Improvement] Optimize return value type for table service interface#208
SteNicholas merged 1 commit intoapache:mainfrom
s7monk:optimize_table_return_type

Conversation

@s7monk
Copy link
Contributor

@s7monk s7monk commented Apr 30, 2024

Relates to: #205

Purpose

This pull request aims to align the return types of our service layer interfaces with standard Spring framework practices by removing the use of a custom response wrapper (R). This change simplifies our service layer, ensuring it focuses solely on business logic and remains agnostic of HTTP response structures, as discussed in Issue #205.

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas SteNicholas changed the title [Feature] Optimize Return Value Type for Table Service Interface [Improvement] Optimize return value type for table service interface May 5, 2024
@SteNicholas SteNicholas merged commit e517cad into apache:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants