[Feature] TableWrite skip null fields check, when RowKind is DELETE

[CompassChengHan]

Search before asking

• I searched in the issues and found nothing similar.

Motivation

When deleting a row from PrimaryKey Table, we can set the RowKind type to RowKind.DELETE.

Currently, the TableWriteImpl class will always invoke checkNullability method, ensure all fileds comply with null constraint,

We suggest only verify primary keys null constraint if RowKind is DELETE, then when delete a row, only need provide primary keys.

Solution

No response

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[JackeyLee007]

Actually, the data will be completed even though only pk provided. And since deletion is rare comparing to insert and update, ignoring other field check wont save too much time.

[JingsongLi]

Actually, the data will be completed even though only pk provided. And since deletion is rare comparing to insert and update, ignoring other field check wont save too much time.

He is not trying to save time, he can only provide the primary key field and no other fields, in order to avoid errors

[JackeyLee007]

But as I tried, it does need only the primary key when deleting a record, eg.

delete from some_table where id = 123;