[core] provide changelog-producer.row-deduplicate to deduplicate same change#1100
Merged
Conversation
FangYongs
reviewed
May 9, 2023
| return options.get(CHANGELOG_PRODUCER); | ||
| } | ||
|
|
||
| public boolean rowDeduplicate() { |
Contributor
There was a problem hiding this comment.
Use changelogRowDeduplicate()?
JingsongLi
approved these changes
May 9, 2023
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @liming30 for the contribution!
The PR looks pretty good. +1
We can create an Issue for introducing RecordEqualiser, it is bit faster than comparator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Provide
changelog-producer.row-deduplicateto deduplicate same change. Closes #634Tests
Modify the following unit test to verify:
org.apache.paimon.mergetree.compact.FullChangelogMergeFunctionWrapperTestBaseorg.apache.paimon.mergetree.compact.LookupChangelogMergeFunctionWrapperTestModify the following integration tests to verify:
org.apache.paimon.flink.FullCompactionFileStoreITCase#testUpdateorg.apache.paimon.flink.LookupChangelogWithAggITCase#testMultipleCompactionAPI and Format
No
Documentation
No