[core] Forbidden no bucket key for bucketed append table#3320
Merged
leaves12138 merged 17 commits intoapache:masterfrom May 13, 2024
Merged
[core] Forbidden no bucket key for bucketed append table#3320leaves12138 merged 17 commits intoapache:masterfrom
leaves12138 merged 17 commits intoapache:masterfrom
Conversation
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the previous behavior, no bucket-key would take the whole line and make it bucket-key, which is a poor performance behavior and we should disable it.
And if there is no bucket-key, why not just using bucket -1 mode? Fixed bucket will bring more performance tuning problem.
Tests
API and Format
Documentation