Skip to content

[flink] Fix the illegal usage of flink.shaded.guava31 dependency in TableSortInfo #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Jun 5, 2024
Merged

[flink] Fix the illegal usage of flink.shaded.guava31 dependency in TableSortInfo #3470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sorter/TableSortInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import java.util.Collections;
import java.util.List;

import static org.apache.flink.shaded.guava31.com.google.common.base.Preconditions.checkArgument;
import static org.apache.flink.shaded.guava31.com.google.common.base.Preconditions.checkNotNull;
import static org.apache.paimon.utils.Preconditions.checkArgument;
import static org.apache.paimon.utils.Preconditions.checkNotNull;

/**
* {@link TableSortInfo} is used to indicate the configuration details for table data sorting. This
Expand Down
7 changes: 7 additions & 0 deletions tools/maven/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,13 @@ This file is based on the checkstyle file of Apache Beam.
<property name="illegalPattern" value="true"/>
<property name="message" value="Use com.fasterxml.jackson instead of jettison."/>
</module>
<!-- forbid the use of flink.shaded.guava31.com.google.common -->
<module name="Regexp">
<property name="format" value="import static org\.apache\.flink\.shaded\.guava31\.com\.google\.common\.base\.Preconditions"/>
<property name="illegalPattern" value="true"/>
<property name="message"
value="Use Paimon's Preconditions instead of Guava's Preconditions"/>
</module>

<!-- Enforce Java-style array declarations -->
<module name="ArrayTypeStyle"/>
Expand Down