Skip to content

[core] Improve performance of dinstinct collect agg. #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 8 commits into from
Jul 18, 2024
Merged

[core] Improve performance of dinstinct collect agg. #3772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cfb56b
[core] Dinstinct collect agg should not distinct distincted accumulat…
leaves12138 Jul 17, 2024
a1d5a86
fix comment
leaves12138 Jul 17, 2024
1584953
fix comment
leaves12138 Jul 17, 2024
264010e
fix comment
leaves12138 Jul 17, 2024
b23686f
fix comment
leaves12138 Jul 18, 2024
3362b93
fix comment
leaves12138 Jul 18, 2024
48cddf7
fix comment
leaves12138 Jul 18, 2024
4532fa7
fix comment
leaves12138 Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private void updateWithSequenceGroup(KeyValue kv) {
row.setField(
i, aggregator == null ? field : aggregator.agg(accumulator, field));
} else if (aggregator != null) {
row.setField(i, aggregator.agg(field, accumulator));
row.setField(i, aggregator.aggReversed(accumulator, field));
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ private static FieldAggregator createFieldNestedUpdateAgg(

public abstract Object agg(Object accumulator, Object inputField);

public Object aggReversed(Object accumulator, Object inputField) {
return agg(inputField, accumulator);
}

/** reset the aggregator to a clean start state. */
public void reset() {}

Expand Down
12 changes: 11 additions & 1 deletion paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldCollectAgg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ String name() {
return NAME;
}

@Override
public Object aggReversed(Object accumulator, Object inputField) {
// we don't need to actually do the reverse here for this agg
// because accumulator has been distinct, just let accumulator be accumulator will speed up
// dinstinct process
return agg(accumulator, inputField);
}

@Override
public Object agg(Object accumulator, Object inputField) {
if (accumulator == null && inputField == null) {
Expand All @@ -99,7 +107,9 @@ public Object agg(Object accumulator, Object inputField) {

if (equaliser != null) {
List<Object> collection = new ArrayList<>();
collectWithEqualiser(collection, accumulator);
// do not need to distinct accumulator, because the accumulator is always distinct, no
// need to distinct it every time
collect(collection, accumulator);
collectWithEqualiser(collection, inputField);
return new GenericArray(collection.toArray());
} else {
Expand Down