[core] Dynamic bucket mode cannot work with AQE#4009
Merged
JingsongLi merged 1 commit intoapache:masterfrom Aug 21, 2024
Merged
[core] Dynamic bucket mode cannot work with AQE#4009JingsongLi merged 1 commit intoapache:masterfrom
JingsongLi merged 1 commit intoapache:masterfrom
Conversation
Zouxxyy
reviewed
Aug 21, 2024
| if (!isStreaming && table.coreOptions().writeManifestCache().getBytes() > 0) { | ||
| assertBatchAdaptiveParallelism(env, written.getParallelism()); | ||
| boolean writeMCacheEnabled = table.coreOptions().writeManifestCache().getBytes() > 0; | ||
| boolean hashDynamicMode = table.bucketMode() == BucketMode.HASH_DYNAMIC; |
Contributor
There was a problem hiding this comment.
what about cross_partition
Contributor
Author
There was a problem hiding this comment.
cross_partition does not rely on reading index, pk index will shuffle with data records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Dynamic bucket mode should know the distribution strategy to filter own data of a task.
If AQE enabled, there is no fixed distribution strategy, task cannot know the its own bucket index.
Tests
API and Format
Documentation