[core] Fix partition column generate wrong partition spec#4349
Merged
JingsongLi merged 2 commits intoapache:masterfrom Oct 23, 2024
Merged
[core] Fix partition column generate wrong partition spec#4349JingsongLi merged 2 commits intoapache:masterfrom
JingsongLi merged 2 commits intoapache:masterfrom
Conversation
ulysses-you
commented
Oct 18, 2024
Contributor
Author
There was a problem hiding this comment.
Move cast related files from core to common due to the InternalRowPartitionComputer is at common.
JingsongLi
requested changes
Oct 20, 2024
Contributor
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @ulysses-you for the contribution.
But this is really dangerous to compatibility. It may be better to keep old style by default.
Contributor
Author
@JingsongLi +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon uses
.toStringto generate partition value, which is not accurate for some data types. like date/binary. Say, Spark engine would use aCastto convert a partition object to string value. So this pr changes to use cast to generate partition value.Add a new config
partition.legacy-nameto support switch to use previoustoStringbehavior, and by default use the legacy behavior(.toString).An example that using binary type partition column would cause failure.
Tests
add test
API and Format
no
Documentation
added docs