[doc] fix doc describes an error about Asynchronous Compaction#4377
Closed
herefree wants to merge 1 commit intoapache:masterfrom
Closed
[doc] fix doc describes an error about Asynchronous Compaction#4377herefree wants to merge 1 commit intoapache:masterfrom
herefree wants to merge 1 commit intoapache:masterfrom
Conversation
wwj6591812
reviewed
Oct 25, 2024
| ```shell | ||
| num-sorted-run.stop-trigger = 2147483647 | ||
| sort-spill-threshold = 10 | ||
| num-sorted-run.stop-trigger = 10 |
Contributor
There was a problem hiding this comment.
I think:
If apply this config, the commit will be block by compaction when the number of sorted-run is 10.
Then writing throughput will decline.
May I ask why you made this modification？
| num-sorted-run.stop-trigger = 2147483647 | ||
| sort-spill-threshold = 10 | ||
| num-sorted-run.stop-trigger = 10 | ||
| sort-spill-threshold = 2147483647 |
Contributor
There was a problem hiding this comment.
I think:
If apply this config, no sorted-run will be spill when compaction or mergeOnRead, maybe cause OOM.
May I ask why you made this modification？
Contributor
Author
There was a problem hiding this comment.
Sorry,I made a mistake.I'll close it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4375
Tests
API and Format
Documentation