[core] The record level expired time field type is automatically recognized.#4458
Merged
JingsongLi merged 2 commits intoapache:masterfrom Nov 6, 2024
Merged
Conversation
wwj6591812
reviewed
Nov 6, 2024
Contributor
wwj6591812
left a comment
wwj6591812
left a comment
There was a problem hiding this comment.
I think this is a good Job.
+1
| .defaultValue(TimeFieldType.SECONDS_INT) | ||
| .withDescription( | ||
| "Time field type for record level expire, it can be seconds-int,seconds-long, millis-long or timestamp."); | ||
| "Time field for record level expire. It supports the following types: `timestamps in seconds with INT`,`timestamps in seconds with BIGINT`, `Timestamps in milliseconds with BIGINT` or `Timestamp`."); |
Contributor
There was a problem hiding this comment.
timestamps in milliseconds with BIGINT or timestamp
Contributor
|
+1, nice job |
Contributor
|
Thanks @zhuangchong , Nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The record level expired time field type is automatically recognized.
The user is not required to enter the field type
record-level.time-field-type, and the input may be incorrect.Tests
API and Format
Documentation