[iceberg] Improved ByteBuffer string conversion for Iceberg manifests#5008
Merged
JingsongLi merged 1 commit intoapache:masterfrom Feb 10, 2025
Merged
Conversation
2 tasks
JingsongLi
approved these changes
Feb 10, 2025
Contributor
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @0dunay0 , looks good to me!
JackeyLee007
pushed a commit
to JackeyLee007/paimon
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon's Iceberg compatibility tables partitioned by a
stringfield doesn't return any results when queried by an equality predicate on the partition field.The effect of these is clients skip all the data files for the Iceberg table during scan planning. See the linked issue for examples.
Linked issue: #5007
Tests
IcebergCompatibilityTestto verify the snapshot metadata files no longer contain the\u000padding.IcebergConversionsCHAR/VARCHAR case.API and Format
N/A
Documentation
N/A