Skip to content

[iceberg] Improved ByteBuffer string conversion for Iceberg manifests#5008

Merged
JingsongLi merged 1 commit intoapache:masterfrom
0dunay0:0dunay0/fix-iceberg-manifest-file-meta
Feb 10, 2025
Merged

[iceberg] Improved ByteBuffer string conversion for Iceberg manifests#5008
JingsongLi merged 1 commit intoapache:masterfrom
0dunay0:0dunay0/fix-iceberg-manifest-file-meta

Conversation

@0dunay0
Copy link
Copy Markdown
Contributor

@0dunay0 0dunay0 commented Feb 3, 2025

Purpose

Paimon's Iceberg compatibility tables partitioned by a string field doesn't return any results when queried by an equality predicate on the partition field.

  • The snapshot file's partition summary lower and upper bounds have a null character suffix.
  • The column stats in the manifest files also contain null character suffix.

The effect of these is clients skip all the data files for the Iceberg table during scan planning. See the linked issue for examples.

Linked issue: #5007

Tests

  • Added a new test case in IcebergCompatibilityTest to verify the snapshot metadata files no longer contain the \u000 padding.
  • Added extensive test cases for the IcebergConversions CHAR/VARCHAR case.

API and Format

N/A

Documentation

N/A

Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0dunay0 , looks good to me!

@JingsongLi JingsongLi merged commit 50d658d into apache:master Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants