Skip to content

[refactor] specialize the type of table to FileStoreTable in FileStoreLookupFunction #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuzelin merged 2 commits into from
Feb 19, 2025
Merged

[refactor] specialize the type of table to FileStoreTable in FileStoreLookupFunction #5108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb40667
[refactor] specialize the type of table to FileStoreTable in FileStor…
LsomeYeah Feb 19, 2025
65ad479
fix checkstyle
LsomeYeah Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions ...on-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.apache.paimon.predicate.Predicate;
import org.apache.paimon.table.BucketMode;
import org.apache.paimon.table.FileStoreTable;
import org.apache.paimon.table.Table;
import org.apache.paimon.table.source.OutOfRangeException;
import org.apache.paimon.utils.FileIOUtils;
import org.apache.paimon.utils.Filter;
Expand Down Expand Up @@ -79,7 +78,7 @@ public class FileStoreLookupFunction implements Serializable, Closeable {

private static final Logger LOG = LoggerFactory.getLogger(FileStoreLookupFunction.class);

private final Table table;
private final FileStoreTable table;
@Nullable private final PartitionLoader partitionLoader;
private final List<String> projectFields;
private final List<String> joinKeys;
Expand Down Expand Up @@ -176,26 +175,19 @@ private void open() throws Exception {
projectFields,
joinKeys);

FileStoreTable storeTable = (FileStoreTable) table;

LOG.info("Creating lookup table for {}.", table.name());
if (options.get(LOOKUP_CACHE_MODE) == LookupCacheMode.AUTO
&& new HashSet<>(table.primaryKeys()).equals(new HashSet<>(joinKeys))) {
if (isRemoteServiceAvailable(storeTable)) {
if (isRemoteServiceAvailable(table)) {
this.lookupTable =
PrimaryKeyPartialLookupTable.createRemoteTable(
storeTable, projection, joinKeys);
PrimaryKeyPartialLookupTable.createRemoteTable(table, projection, joinKeys);
LOG.info(
"Remote service is available. Created PrimaryKeyPartialLookupTable with remote service.");
} else {
try {
this.lookupTable =
PrimaryKeyPartialLookupTable.createLocalTable(
storeTable,
projection,
path,
joinKeys,
getRequireCachedBucketIds());
table, projection, path, joinKeys, getRequireCachedBucketIds());
LOG.info(
"Remote service isn't available. Created PrimaryKeyPartialLookupTable with LocalQueryExecutor.");
} catch (UnsupportedOperationException ignore) {
Expand All @@ -210,7 +202,7 @@ private void open() throws Exception {
if (lookupTable == null) {
FullCacheLookupTable.Context context =
new FullCacheLookupTable.Context(
storeTable,
table,
projection,
predicate,
createProjectedPredicate(projection),
Expand Down