Skip to content

[core] Fix incremental query with delete after minor compact#5115

Merged
JingsongLi merged 1 commit intoapache:masterfrom
Zouxxyy:dev/fix-increment-read
Feb 20, 2025
Merged

[core] Fix incremental query with delete after minor compact#5115
JingsongLi merged 1 commit intoapache:masterfrom
Zouxxyy:dev/fix-increment-read

Conversation

@Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Feb 19, 2025

Purpose

Due to the possibility that the before files and after files may offset each other during incremental read, while there are also new deletes in after files, we cannot drop deletes when reading after files.

//            tag1                          tag2
// l0         f(+I 10001),f(+I 10002)       f(-D 999)
// l1
// l2
// l3
// l4                                       f(+I 10001,10002)
// l5         f(+I 1-10000)                 f(+I 1-10000)

// before files: f(+I 10001), f(+I 10002)
// after files:  f(-D 999),   f(+I 10001,10002)

Tests

API and Format

Documentation

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @Zouxxyy

@JingsongLi JingsongLi merged commit d4edc22 into apache:master Feb 20, 2025
12 checks passed
@Zouxxyy Zouxxyy deleted the dev/fix-increment-read branch February 20, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants