Skip to content

[core]RESTCatalog: update http code 500 response is ErrorResponse#5359

Merged
JingsongLi merged 9 commits intoapache:masterfrom
jerry-024:fix-open-api
Mar 31, 2025
Merged

[core]RESTCatalog: update http code 500 response is ErrorResponse#5359
JingsongLi merged 9 commits intoapache:masterfrom
jerry-024:fix-open-api

Conversation

@jerry-024
Copy link
Copy Markdown
Contributor

@jerry-024 jerry-024 commented Mar 27, 2025

Purpose

RESTCatalog: update http code 500 response to ErrorResponse
Linked issue: #4540

Tests

API and Format

Documentation

@jerry-024 jerry-024 marked this pull request as draft March 27, 2025 09:24
@jerry-024 jerry-024 changed the title [core]RESTCatalog: fix open api [core]RESTCatalog: update http code 500 response is ErrorResponse Mar 27, 2025
@XiaoHongbo-Hope
Copy link
Copy Markdown
Contributor

Thanks

@jerry-024 jerry-024 marked this pull request as ready for review March 28, 2025 08:30
application/json:
schema:
$ref: '#/components/schemas/ErrorResponse'
$ref: '#/components/responses/ResourceHasExistErrorResponse'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add 400 bad request error for all create/alter api?

@XiaoHongbo-Hope
Copy link
Copy Markdown
Contributor

Thanks jerry, looks good to me

Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit ee08d83 into apache:master Mar 31, 2025
18 of 19 checks passed
@jerry-024 jerry-024 deleted the fix-open-api branch June 5, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants