Skip to content

[core] Optimize equals and hashCode implementation in Snapshot #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Mar 31, 2025
Merged

[core] Optimize equals and hashCode implementation in Snapshot #5375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions paimon-core/src/main/java/org/apache/paimon/Snapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,12 +424,16 @@ public int hashCode() {
totalRecordCount,
deltaRecordCount,
changelogRecordCount,
watermark);
watermark,
statistics);
}

@Override
public boolean equals(Object o) {
if (!(o instanceof Snapshot)) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
Snapshot that = (Snapshot) o;
Expand All @@ -451,7 +455,8 @@ public boolean equals(Object o) {
&& Objects.equals(totalRecordCount, that.totalRecordCount)
&& Objects.equals(deltaRecordCount, that.deltaRecordCount)
&& Objects.equals(changelogRecordCount, that.changelogRecordCount)
&& Objects.equals(watermark, that.watermark);
&& Objects.equals(watermark, that.watermark)
&& Objects.equals(statistics, that.statistics);
}

/** Type of changes in this snapshot. */
Expand Down