Skip to content

[hotfix] Fix test WithPartialUpdateMergeFunctionTest #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Apr 9, 2025
Merged

[hotfix] Fix test WithPartialUpdateMergeFunctionTest #5425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...on-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ public void reset() {
this.meetInsert = false;
this.notNullColumnFilled = false;
this.row = new GenericRow(getters.length);
this.latestSequenceNumber = 0;
fieldAggregators.values().forEach(FieldAggregator::reset);
}

Expand Down
8 changes: 3 additions & 5 deletions paimon-core/src/test/java/org/apache/paimon/mergetree/compact/MergeFunctionTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,10 @@ public static List<ReusingTestData> getExpectedForPartialUpdate(
expected.add(group.get(group.size() - 1));
} else {
if (group.stream().noneMatch(data -> data.valueKind == RowKind.INSERT)) {
// No insert: fill the pk and left nullable fields to null; sequenceNumber =
// latest
// No insert: fill the pk and left nullable fields to null; sequenceNumber = 0
// because it's not updated
ReusingTestData last = group.get(group.size() - 1);
expected.add(
new ReusingTestData(
last.key, last.sequenceNumber, RowKind.DELETE, null));
expected.add(new ReusingTestData(last.key, 0, RowKind.DELETE, null));
} else {
// get the last INSERT data because later DELETE data are ignored
group.stream()
Expand Down
Loading