Merged
Conversation
Contributor
|
Hi @cxzl25 , we have introduced git commit id before, but many developers have reported that compilation will be much slower, so we have removed commit id. |
Contributor
Author
Tested, it was a little different. M2 Max time mvn clean package -DskipTestsmaster 506.56s user 62.62s system 178% cpu 5:18.58 totalPR 513.05s user 76.75s system 97% cpu 10:06.45 total
So can we remove these lines? It seems that in the new version of release there is no commit id Lines 481 to 483 in 7f6e574 |
Contributor
Yes, we should remove these lines. |
This reverts commit e5dac7d.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
025c032#commitcomment-161263081
Tests
API and Format
Documentation