Skip to content

[pom] Remove SCM-Revision#5854

Merged
JingsongLi merged 3 commits intoapache:masterfrom
cxzl25:add_git_commit_plugin
Jul 9, 2025
Merged

[pom] Remove SCM-Revision#5854
JingsongLi merged 3 commits intoapache:masterfrom
cxzl25:add_git_commit_plugin

Conversation

@cxzl25
Copy link
Copy Markdown
Contributor

@cxzl25 cxzl25 commented Jul 8, 2025

Purpose

Linked issue: close #xxx

025c032#commitcomment-161263081

Tests

API and Format

Documentation

@cxzl25 cxzl25 changed the title Add git-commit-id-plugin [pom] Add git-commit-id-plugin Jul 8, 2025
@JingsongLi
Copy link
Copy Markdown
Contributor

Hi @cxzl25 , we have introduced git commit id before, but many developers have reported that compilation will be much slower, so we have removed commit id.

@cxzl25
Copy link
Copy Markdown
Contributor Author

cxzl25 commented Jul 9, 2025

but many developers have reported that compilation will be much slower

Tested, it was a little different. M2 Max

time mvn clean package -DskipTests

master

506.56s user 62.62s system 178% cpu 5:18.58 total

PR

513.05s user 76.75s system 97% cpu 10:06.45 total

removed commit id

So can we remove these lines? It seems that in the new version of release there is no commit id

paimon/pom.xml

Lines 481 to 483 in 7f6e574

<manifestEntries>
<SCM-Revision>${git.commit.id}</SCM-Revision>
</manifestEntries>

@JingsongLi
Copy link
Copy Markdown
Contributor

So can we remove these lines? It seems that in the new version of release there is no commit id

Yes, we should remove these lines.

@cxzl25 cxzl25 changed the title [pom] Add git-commit-id-plugin [pom] Remove SCM-Revision Jul 9, 2025
@JingsongLi
Copy link
Copy Markdown
Contributor

+1

@JingsongLi JingsongLi merged commit c3cd3da into apache:master Jul 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants