[core] Revert "If overwrite an empty partition, change commit kind to APPEND (#6795)" #7010
+6
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This feature has caused some problem (for example, overwrite a new partition, the snapshot is committed successfully but the rest interface return fail, then the commit will be retry, and because the second commit kind is OVERWRITE, the conflict check will be ignored and cause data corruption).
To avoid other potential problem, it's better to revert it.
Tests
API and Format
Documentation